All committers have signed the CLA.

docker is a class

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Thanks for your contribution and good suggestions @bastelfreak @kenyon !
Can someone take a look at the unit/acceptance tests?

In my opinion at least spec/shared_examples/repos.rb line 24-29 need some adjustment.

Yes, tests should be added or updated to test this new code.

Added some working unit-tests with 5373dea
Since I am not very familiar with rspec there are probably cleaner solutions.
Please feel free to suggest! :)

Since acceptance tests already check if installation of docker is working (and using sources is a part of it) I think there are no additional acceptance tests needed.

@kenyon @bastelfreak for some reason the PR Test / Windows 2022, puppet6-nightly keeps failing.
Do you have any idea? 😄

docker is a class

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

#rebased
@bastelfreak @david22swan
Please run tests and feel free to review + merge.

@bastelfreak can you approve the workflows?

@bastelfreak can you approve the workflows?

Failed tests are not related to Puppet code.
Can we merge this ?

Apologies for the delay in response @vegaaz!
There is a fix currently being worked that should resolve the test failures present, so once thats merged in we can rekick these tests and ensure they are green before continuing.

Thanks for all the work on this one!

Branch rebased
Could you please run tests @bastelfreak @jordanbreen28 ? :)

Windows 2022 nightly tests are failing because of:
„Timeout after 10 seconds connecting“

@bastelfreak @jordanbreen28 how do we handle this ? Try again ?

Bump @jordanbreen28 @bastelfreak

Sorry for the delay @vegaaz..
The timeout errors is a known issue to us & not related to your code changes.

There are some bits of work ongoing in this module that we'd like to get in first before moving on with this (like support for Puppet 8), but I've made a note so this PR doesn't sit idle waiting for a response on us like it has done. (Apologies again..)

Hey @vegaaz!
The work I mentioned above has been merged in now, do you want to resolve this branches conflicts and we will think about progressing this?
Thanks

docker is a class

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Hey @vegaaz! The work I mentioned above has been merged in now, do you want to resolve this branches conflicts and we will think about progressing this? Thanks

Hi @jordanbreen28 I rebased the Branch.
Lets take a look! :)